blek
/
bfile
1
0
Fork 0
Code Issues 6 Pull Requests 1 Packages Projects Releases 1 Wiki Activity

Fix files naming #24

Merged
blek merged 3 commits from fix-naming into 0.2-dev 2023-12-11 00:56:44 +01:00
Conversation 5 Commits 3 Files Changed 2 +15 -14
blek commented 2023-12-09 13:15:46 +01:00
Owner
Copy Link

This PR does:

  1. Fixes #23
  2. Refactors a bit of code in filed/src/files/lookup.rs for readibility
This PR does: 1. Fixes #23 2. Refactors a bit of code in `filed/src/files/lookup.rs` for readibility
blek added 2 commits 2023-12-09 13:15:46 +01:00
blek commented 2023-12-09 13:16:26 +01:00
Author
Owner
Copy Link

Thanks! I will review this in a few days.

Thanks! I will review this in a few days.
blek reviewed 2023-12-10 16:46:06 +01:00
filed/src/files/lookup.rs Outdated
@ -111,2 +111,3 @@
LookupKind::ByName => {
if (&file).name.is_none() {
if let Some(name) = file.name.clone() {
log::debug!("Using {} as a custom file name", name);
blek commented 2023-12-10 16:45:55 +01:00
Author
Owner
Copy Link

breaks dry? see line 130 as well. not quite sure if thats a bad thing

breaks dry? see line 130 as well. not quite sure if thats a bad thing
blek commented 2023-12-10 16:51:36 +01:00
Author
Owner
Copy Link

@blek any comments on this? i am unsure if we really should stick with dry on this one

@blek any comments on this? i am unsure if we really should stick with dry on this one
blek reviewed 2023-12-10 16:53:06 +01:00
filed/src/files/lookup.rs Outdated
@ -113,0 +116,4 @@
format!(
"{}{}{}",
self.env.redis.prefix,
midfix,
blek commented 2023-12-10 16:53:06 +01:00
Author
Owner
Copy Link

i'd say that if we're not sticking with dry then there is no need for that midfix variable. could've just hardcoded the -(name|hash)- thing to make it more apparent

i'd say that if we're not sticking with dry then there is no need for that `midfix` variable. could've just hardcoded the `-(name|hash)-` thing to make it more apparent
blek commented 2023-12-10 16:54:09 +01:00
Author
Owner
Copy Link

yeah, i agree. that variable being assigned at the start of the code is pretty much just the useless clutter now

yeah, i agree. that variable being assigned at the start of the code is pretty much just the useless clutter now
blek added 1 commit 2023-12-10 17:43:04 +01:00
blek commented 2023-12-10 17:43:30 +01:00
Author
Owner
Copy Link

this is so stupid. can we just merge this now?

this is so stupid. can we just merge this now?
blek commented 2023-12-11 00:56:35 +01:00
Author
Owner
Copy Link

seems all good to me

seems all good to me
blek merged commit ea15e25fe2 into 0.2-dev 2023-12-11 00:56:44 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/TODO

   
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Service
filed
This issue/PR is about filed

  
Service
janitord
This issue/PR is about janitord

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Controversial

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Status
Not planned

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/TODO
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Service
filed
Service
janitord
Status
Abandoned
Status
Blocked
Status
Controversial
Status
Need More Info
Status
Not planned
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blek/bfile#24
No description provided.
Delete Branch "fix-naming"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?